Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invert-color #1010

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Fix invert-color #1010

merged 2 commits into from
Oct 22, 2020

Conversation

brongulus
Copy link
Contributor

@brongulus brongulus commented Oct 21, 2020

invert-color bookmarklet was unreliable, didn't work and wasn't toggle-able, this new JS code makes it toggleable and reliable. Might fix #362

invert-color bookmarklet was unreliable, didn't work and wasn't toggle-able, this new JS code makes it toggleable and reliable.
@Ambrevar
Copy link
Member

Thanks!

Did you write this Javascript yourself or did you copy-paste it from somewhere else?
If the former, would you like to write it in Parenscript instead?
If the latter, can you mention the source?

#362 is more about per-domain stylesheets and support for existing Dark CSS sheets.

@brongulus
Copy link
Contributor Author

brongulus commented Oct 21, 2020

@jmercouris
Copy link
Member

I don't think we can use it in any case because it is published without a license from that source. If the author has published it elsewhere with a license, then we can take a look.

@jmercouris
Copy link
Member

Thank you for looking into this!

@brongulus
Copy link
Contributor Author

If the author has published it elsewhere with a license, then we can take a look.

I could try to contact them and ask for a licensed version? Would that be acceptable, since the current version of invert-color doesn't work at all.

@jmercouris
Copy link
Member

Yes, that would be wonderful!

@frontdevops
Copy link

frontdevops commented Oct 21, 2020

Hi! Use my code however you like. If necessary, I can create a repository where I will write that the license is free.
No problem, use this code at your own discretion, I will only be glad. Free license: take whoever you want, do what you want

@frontdevops
Copy link

I create it

https://github.com/frontdevops/darkthemeswitcher-inline

@jmercouris
Copy link
Member

Thanks so much :-)

@Ambrevar
Copy link
Member

@brongulus Can you edit your patch to include a comment referencing the origin of the bookmarklet then?
Thanks!

@brongulus
Copy link
Contributor Author

Done :)

@jmercouris jmercouris merged commit 38931d0 into atlas-engineer:master Oct 22, 2020
@jmercouris
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Custom stylesheets (CSS), e.g. Dark Mode support
4 participants