-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invert-color #1010
Fix invert-color #1010
Conversation
invert-color bookmarklet was unreliable, didn't work and wasn't toggle-able, this new JS code makes it toggleable and reliable.
Thanks! Did you write this Javascript yourself or did you copy-paste it from somewhere else? #362 is more about per-domain stylesheets and support for existing Dark CSS sheets. |
I copied it from here: |
I don't think we can use it in any case because it is published without a license from that source. If the author has published it elsewhere with a license, then we can take a look. |
Thank you for looking into this! |
I could try to contact them and ask for a licensed version? Would that be acceptable, since the current version of invert-color doesn't work at all. |
Yes, that would be wonderful! |
Hi! Use my code however you like. If necessary, I can create a repository where I will write that the license is free. |
Thanks so much :-) |
@brongulus Can you edit your patch to include a comment referencing the origin of the bookmarklet then? |
Done :) |
Thank you! |
invert-color bookmarklet was unreliable, didn't work and wasn't toggle-able, this new JS code makes it toggleable and reliable. Might fix #362