Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.org #117

Merged
merged 2 commits into from Aug 23, 2018
Merged

Update README.org #117

merged 2 commits into from Aug 23, 2018

Conversation

chuchana
Copy link
Contributor

Added Arch package name for WebKitGTK+
Clarified path for next-gtk binary

Added Arch package name for WebKitGTK+
Clarified path for next-gtk binary
@@ -126,7 +127,7 @@ In a new Terminal execute the following:
: cd next/next
: make build-gtk

the compiled binary will be present in source/next-gtk.
the compiled binary will be present in the directory ~source~ as ~next-gtk~.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was source/next-gtk confusing? Don't know, I might be biased.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread it as a path to a directory because of the word in, so I had a bit of trouble finding it at first. It might just be me, but I thought getting rid of that potential ambiguity couldn't hurt.

next/README.org Outdated
@@ -90,6 +90,7 @@ Find a package for your distribution which provides

For Ubuntu this package is ~libwebkit2gtk-4.0-dev~
For Debian this package is ~libwebkit2gtk~
For Arch this package is [~webkit2gtk~](https://www.archlinux.org/packages/extra/x86_64/webkit2gtk/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax for links in Org is [[URL][TITLE]].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@jmercouris jmercouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution to the documentation! I’m sorry for my delay in approving!

@jmercouris jmercouris merged commit f43cae6 into atlas-engineer:master Aug 23, 2018
@Ambrevar Ambrevar mentioned this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants