Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gemini support. #2024
Gemini support. #2024
Changes from all commits
eb26e17
2efcf72
94be32e
6dadde4
db756b0
7a595cd
de1185b
7f8d59c
8933cc6
5fe3bdf
f09ae12
d25d124
98d1dec
eed749e
1f59f37
71918d5
22dd017
48d9068
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why prefixing with "gopher"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's also
gemini-render
:)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we have 2 methods specializations here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, no way -- gemini page body is a string (or a list of gemini objects if we parse it before rendering), while gopher rendering is line-oriented. Specializing against string doesn't feel right, so I'd better stay with two distinctly named functions.
Let me move the body of
gemini-render
intoprocess-gemini-scheme
in source/renderer/gtk.lisp. It will be a bit more coherent this way.However, I'd leave
gopher-render
as it is, as it's Gopher-specific (likesearch-gopher
) while everything else in small-web.lisp isn't.