buffer: Remove obsolete actions-on-return.

[aadcg]

The assignment of this action is a no-op since the actions for these sources are re-defined elsewhere.

Also, setting buffer-load as an action-on-return is not valid. See buffer-load* for the action that is valid.

Description

Minor clean up.

Developed in the context of PR #2772.

Discussion

Read the commit message for an explanation of the rationale.

Checklist:

Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.

• I have pulled from master before submitting this PR
• There are no merge conflicts.
• I've added the new dependencies as:
  • ASDF dependencies,
  • Git submodules,

    cd /path/to/nyxt/checkout
    git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser

  • and Guix dependencies.
• My code follows the style guidelines for Common Lisp code. See:
  • Norvig & Pitman's Tutorial on Good Lisp Programming Style (PDF)
  • Google Common Lisp Style Guide
• I have performed a self-review of my own code.
• My code has been reviewed by at least one peer. (The peer review to approve a PR counts. The reviewer must download and test the code.)
• Documentation:
  • All my code has docstrings and :documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)
  • I have updated the existing documentation to match my changes.
  • I have commented my code in hard-to-understand areas.
  • I have updated the changelog.lisp with my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).
  • I have added a migration.lisp entry for all compatibility-breaking changes.
  • (If this changes something about the features showcased on Nyxt website) I have these changes described in the new/existing article at Nyxt website or will notify one of maintainters to do so.
• Compilation and tests:
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works. (If possible.)
  • New and existing unit tests pass locally with my changes.

[aartaka]

I mean, yes, these sources are used with custom actions on return in Nyxt code. But they may also be used in user config and extensions, in which case we'd better retain some meaningful action on return, even though we don't use it ourselves.

[aadcg]

@aartaka If I understood you correctly, you're suggesting the new changes that I've pushed.

[aartaka]

I didn't anticipate this turn of events, but it's a good refactoring in the end （゜◇゜）

[aadcg]

Ok to merge @Ambrevar?

[Ambrevar]

OK!

[aadcg]

Thanks!

[jmercouris]

Thank you!