mode/bookmarklets: Fix darken / dark-mode #2971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, javascript code is now executed as is. Preprocessing
with quri is removed. A reason for this:
NYXT-USER> (quri:uri-path (quri:uri "javascript:document.querySelectorAll('*').forEach(e=>e.setAttribute('style','background-color:atlas-engineer#222 !important;background-image:none !important;color:#'+(/^A|BU/.test(e.tagName)?'36c;text-decoration:underline;':'eee;')+e.getAttribute('style')))"))
"document.querySelectorAll('*').forEach(e=>e.setAttribute('style','background-color:"
"javascript:" prefix is removed from bookmarklet commands (only
DARKEN used this prefix).
aartaka
reviewed
May 23, 2023
| @@ -26,11 +26,7 @@ By default, this mode does nothing but expose the default bookmarklet commands." | |||
| `(let* ((source ,source) | |||
| (source (etypecase source | |||
| (pathname (files:content (make-instance 'files:file :base-path source))) | |||
| (string source))) | |||
| (source (if (str:starts-with-p "javascript:" source) | |||
There was a problem hiding this comment.
I'd rather retain the javascript: checking, even if without the quri part. Care to get it back?
The proper implementation, in my opinion, is to strip the scheme and to decode the URL.
|
@aartaka OK, I'll do it, but I'am very busy at university right now, so my nyxt hacking will have to wait (mostly) :( |
|
Fix pushed as f073f7d, thanks for suggesting this change! |
aadcg
pushed a commit
that referenced
this pull request
Jun 12, 2023
Note that this unreliability only applies to bookmarks, because they have a very relaxed format. Regular javascript: links are much more likely to have a proper QURI-parseable format. Thus the fix locality. Closes #2971.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've removed a preprocessing step which used quri to parse links like
javascript:<javascript code>. It worked incorrectly anddarkenwas broken because of this:(I've added few newlines for this example, but it doesn't really matter.)