Refactor object attributes #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadcg
commented
Mar 20, 2024
| (sera:and-let* ((suggestions (prompter:suggestions source)) | ||
| (fourth-attributes | ||
| (mapcar #'fourth (prompter:active-attributes (first suggestions) :source source))) | ||
| (coefficients (substitute 1 nil fourth-attributes))) |
aadcg
force-pushed
the
refactor-object-attributes
branch
from
30c7733
to
ca58459
Compare
|
Please let me know when this is ready for review! |
jmercouris
approved these changes
Mar 25, 2024
aadcg
force-pushed
the
refactor-object-attributes
branch
2 times, most recently
from
01bd4fb
to
e9b013d
Compare
Please always wait until I change the draft status. Ready for review now. |
|
I shall review this tomorrow! |
For each of the attribute lists, ATTRIBUTE-VALUE is always interpreted as a valid HTML string. (ATTRIBUTE-KEY ATTRIBUTE-VALUE ...)
Deprecate dynamic-attribute-width-p slot. Fix logic of width allocation. Minor review of all prompter:object-attributes methods, namely the order of attributes and their visibility state.
aadcg
force-pushed
the
refactor-object-attributes
branch
from
e9b013d
to
738bdd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2782
Found and fixed a bug upstream in the process, see atlas-engineer/prompter@0038eb2.
Checklist:
(asdf:test-system :nyxt/<renderer>))