Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng-packagr doesn't support CSS @import #1655

Closed
igarashitm opened this issue Jan 10, 2020 · 0 comments · Fixed by #1660
Closed

ng-packagr doesn't support CSS @import #1655

igarashitm opened this issue Jan 10, 2020 · 0 comments · Fixed by #1660
Assignees
@igarashitm
Labels
cat/bug cat/build For issues which have relevance for the build system group/ui prio/p0

Comments

@igarashitm
Copy link
Member

Due to this issue, Data Mapper layout breaks in Syndesis
syndesisio/syndesis#7519

cf. ng-packagr/ng-packagr#643

Thanks to this article, there seem to be a way to inline them programatically. Add preprocessing for it.
https://medium.com/@Dor3nz/compiling-css-in-new-angular-6-libraries-26f80274d8e5
@igarashitm igarashitm added group/ui cat/bug prio/p0 cat/build For issues which have relevance for the build system labels Jan 10, 2020
@igarashitm igarashitm self-assigned this Jan 10, 2020
@igarashitm igarashitm mentioned this issue Jan 13, 2020
Closed
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Jan 13, 2020
@igarashitm
fix: ng-packagr doesn't support CSS @import
e34e62b 
Fixes: atlasmap#1655
@igarashitm igarashitm mentioned this issue Jan 13, 2020
Merged
igarashitm added a commit that referenced this issue Jan 13, 2020
@igarashitm
fix: ng-packagr doesn't support CSS @import
7fbd73f 
Fixes: #1655
@igarashitm igarashitm mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
cat/bug cat/build For issues which have relevance for the build system group/ui prio/p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ng-packagr doesn't support CSS @import igarashitm/atlasmap
1 participant
@igarashitm