Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to AtlasMap 1.43.0 - 1.9x. #7519

Closed
wants to merge 2 commits into from
Closed

chore: Update to AtlasMap 1.43.0 - 1.9x. #7519

wants to merge 2 commits into from

Conversation

zregvart
Copy link
Member

@zregvart zregvart commented Jan 9, 2020

Backport of #7513 and #7517 to 1.9.x

@zregvart
chore: Update to AtlasMap 1.43.0 (syndesisio#7513)
5e2234e 
chore: Update to AtlasMap 1.43.0
(cherry picked from commit 6ef7629)
@zregvart
chore(deps): update yarn.lock
506c194 
A followup on syndesisio#7513 to update the `yarn.lock` file.

(cherry picked from commit 169637e)
@pull-request-size pull-request-size bot added the size/s Small label Jan 9, 2020
@zregvart
Copy link
Member Author

zregvart commented Jan 9, 2020

retest this please

@heiko-braun heiko-braun added the pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. label Jan 10, 2020
@heiko-braun
Copy link
Collaborator

Please hold this until we have feedback from @tplevko and @mcada

@heiko-braun
Copy link
Collaborator

Quoting @mcada

regarding AtlasMap upgrade it does not look good, you can try and compare old look and the new one. From my pov it looks worse.
Also it probably changed many of older selectors so we have to prepare a fix into our testsuite. I think that we should not put it into
ER1. I will ask Tomas Plevko who is working on atlasmap testing to prepare PR with fixes into our testsuite based on the failed PR
and to get in touch with Engineers to fix the look of UI.

@igarashitm Can you work with @tplevko to sort out the QE concerns?

@igarashitm
Copy link
Member

igarashitm commented Jan 10, 2020 •
edited

This layout corruption might be caused by this CSS reafactoring, since this doesn't happen with standalone, have to look at how Syndesis imports AtlasMap CSS (@pleacu or anybody knows?)
atlasmap/atlasmap#1193

Currently I can't have latest syndesis-ui pod on my minishift due to some build problem, it seems like syndesis-ui pod is still working with atlasmap 1.38.1 where it should be 1.43.0

@igarashitm igarashitm mentioned this pull request Jan 10, 2020
Closed
@igarashitm
Copy link
Member

Closing - we'll make another AtlasMap release to get around atlasmap/atlasmap#1655 issue.

@igarashitm igarashitm closed this Jan 13, 2020
@zregvart zregvart deleted the backport/7513-7517 branch January 13, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. size/s Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zregvart @heiko-braun @igarashitm @oscerd