-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use requirements file for install_requires #1298
Use requirements file for install_requires #1298
Conversation
I'd advise against this solution, since For more info see https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/ |
Well, not entirely true it's not desired.
This PR is not about replacing anything with requirements file, but it feeds If you install atlassian-python-api (let' say version 3.41.0) on clean venv, you will notice library Are there any close plans to get rid of all details inside setup.py and use setup.cfg? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
=======================================
Coverage 34.36% 34.36%
=======================================
Files 45 45
Lines 8241 8241
Branches 1146 1146
=======================================
Hits 2832 2832
Misses 5295 5295
Partials 114 114 ☔ View full report in Codecov by Sentry. |
That's up to the maintainer of the project. I was just making people aware about that (unfortunately common) bad practice. If agreed, I would raise a PR myself porting changes to |
@FCamborda could you send the PR, I will merge it |
Guys, this change has broken my build. When installing Atlassian now on an Ubuntu-22 container, it fails to complete because it cannot find krb5-config. Is this due to the addition of the 'optional' kerberos dependency or is there another change that happened that's caused this?
|
Sorry I did not do this before, but I was completely unfamiliar with forks. |
Let's define
install_requires
insidesetup.py
out ofrequirements.txt
file.We keep then only one source of dependencies and we let build fail early (on wheel build) if
requirements.txt
contains wrong dependencies.