Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert misuse of programmatical approach in setup.py #1303

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

FCamborda
Copy link
Contributor

setup.py was ditched a long time ago and newer PEPs recommend using setup.cfg or pyproject.toml

The last changes in setup.py created a misdirected dependency between requirements.txt and setup.py, which included an optional dependency that is causing problems upstreams.

This PR merely reverts those changes in favour for the old already-working setup.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1045f57) 34.49% compared to head (21993fd) 34.49%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1303   +/-   ##
=======================================
  Coverage   34.49%   34.49%           
=======================================
  Files          45       45           
  Lines        8257     8257           
  Branches     1146     1146           
=======================================
  Hits         2848     2848           
  Misses       5295     5295           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 9c6f517 into atlassian-api:master Jan 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants