Skip to content

Commit

Permalink
fix otel collector example (open-telemetry#1006)
Browse files Browse the repository at this point in the history
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
  • Loading branch information
stefanprisca and MrAlias committed Jul 31, 2020
1 parent 423183e commit fc1ce6c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
7 changes: 4 additions & 3 deletions example/otel-collector/k8s/otel-collector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ data:
extensions:
health_check: {}
exporters:
jaeger_grpc:
jaeger:
endpoint: "jaeger-collector.observability.svc.cluster.local:14250"
insecure: true
prometheus:
endpoint: 0.0.0.0:8889
namespace: "testapp"
Expand All @@ -49,7 +50,7 @@ data:
traces:
receivers: [otlp]
processors: []
exporters: [jaeger_grpc]
exporters: [jaeger]
metrics:
receivers: [otlp]
Expand Down Expand Up @@ -114,7 +115,7 @@ spec:
env:
- name: GOGC
value: "80"
image: otel/opentelemetry-collector:0.5.0
image: otel/opentelemetry-collector:0.6.0
name: otel-collector
resources:
limits:
Expand Down
6 changes: 5 additions & 1 deletion example/otel-collector/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"go.opentelemetry.io/otel/api/kv"
"go.opentelemetry.io/otel/api/metric"
"go.opentelemetry.io/otel/api/standard"
apitrace "go.opentelemetry.io/otel/api/trace"
"go.opentelemetry.io/otel/exporters/otlp"
"go.opentelemetry.io/otel/sdk/metric/controller/push"
"go.opentelemetry.io/otel/sdk/metric/selector/simple"
Expand Down Expand Up @@ -102,7 +103,10 @@ func main() {
defer valuerecorder.Unbind()

// work begins
ctx, span := tracer.Start(context.Background(), "CollectorExporter-Example")
ctx, span := tracer.Start(
context.Background(),
"CollectorExporter-Example",
apitrace.WithAttributes(commonLabels...))
for i := 0; i < 10; i++ {
_, iSpan := tracer.Start(ctx, fmt.Sprintf("Sample-%d", i))
log.Printf("Doing really hard work (%d / 10)\n", i+1)
Expand Down

0 comments on commit fc1ce6c

Please sign in to comment.