New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from localhost to 0.0.0.0 by default for all receivers #1006
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 198 198
Lines 14169 14169
=======================================
Hits 12233 12233
Misses 1480 1480
Partials 456 456
Continue to review full report at Codecov.
|
@flands please resolve the conflict. |
And fix the build, please. |
@tigrannajaryan @bogdandrutu @jrcamp -- apologies for the delay, ready for another look. |
Can we have an env var like |
We'll be back to the original problem when people just don't know they need to do it. |
@flands please resolve conflicts. |
…ector into flands/0.0.0.0 * 'master' of github.com:open-telemetry/opentelemetry-collector: Add Grafana as an Adopter (open-telemetry#1095) Decentralize component documentation (open-telemetry#1089) Prevent the chance of a panic on shutdown of load scraper (open-telemetry#1091) Convert cpu/time to cpu/usage and correct unit / data type (open-telemetry#1092)
My point was almost everywhere outside k8s, people can use localhost and for k8s we provide example config (and in near future helm charts). Such config and helm charts could default to 0.0.0.0. |
internal/data/opentelemetry-proto-gen/collector/metrics/v1/metrics_service.pb.go
Outdated
Show resolved
Hide resolved
@owais is this true though? If I am running a standalone Collector on a physical machine or VM how does "localhost" work? I still need to listen to external interfaces to receive connections from other machines. |
In my experience people generally put collector behind a reverse proxy like nginx or ambassador and don't expose the collector directly to the internet. But in any case, I was just throwing ideas into the mix. Not insisting we definitely do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@flands the cla bot is not approving, not sure why. Can you retrigger the build maybe? |
…elemetry#1006) Switch from localhost to 0.0.0.0 by default Link to tracking Issue: Addresses open-telemetry#592
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Description: Switch from localhost to 0.0.0.0 by default
Link to tracking Issue: Addresses #592
Testing: Local
Documentation: Updated as needed