Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blocked] Use React namespace import instead of default import #164

Closed
wants to merge 1 commit into from
Closed

[Blocked] Use React namespace import instead of default import #164

wants to merge 1 commit into from

Conversation

itsdouges
Copy link
Collaborator

@itsdouges itsdouges commented Apr 20, 2020 •
edited
Loading 

git clone git@github.com:atlassian-labs/compiled-css-in-js.git
git checkout react-namespace-import
yarn
yarn test packages/ts-transform/src/styled-component/__tests__/index.test.tsx --watch

Unfortunately this is blocked because if we move to namespace imports the TypeScript compiler just gets rid of the imports.

I've targetted one test with .only that shows this behaviour happening.

Links:
microsoft/TypeScript#14419 (comment)
microsoft/TypeScript#34547

@itsdouges itsdouges added chore 🧹 It's something tedious blocked 🚫 This can't be completed because of something else labels Apr 20, 2020
@itsdouges itsdouges mentioned this pull request Apr 20, 2020
Closed
@itsdouges itsdouges changed the title Use React namespace import instead of default import [Blocked] Use React namespace import instead of default import Apr 20, 2020
@itsdouges itsdouges mentioned this pull request Apr 20, 2020
Closed
@itsdouges itsdouges closed this Apr 22, 2020
@itsdouges itsdouges mentioned this pull request Apr 23, 2020
Closed
@itsdouges itsdouges deleted the react-namespace-import branch April 23, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked 🚫 This can't be completed because of something else chore 🧹 It's something tedious
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itsdouges