This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
golangci-lint does not depend on SDK libs #51
Assignees
Comments
terinjokes
added a commit
to terinjokes/bazel-tools
that referenced
this issue
Mar 12, 2019
This changeset adds two transitive dependencies to the golangci-lint rules: 1. The compiled libraries from the Go SDK, to allow the `govet` linter to run without a warning that it can't initialize the standard library. 2. The `go` binary from the configured SDK, to ensure the linter always uses the same Go binary as the rest of the Bazel build. This also allows this rule to execute in environments (or sandboxes) that otherwise don't have Go installed. Bug: atlassian#50 Bug: atlassian#51
|
@terinjokes if you send a PR I'll happily merge it. Also, sign the CLA please if you do so. |
|
Hey Mikhail.
It doesn't look like I can view the CLA without providing personal
information to DocuSign. So I don't think I'll be doing so.
Hopefully my bug reports provide enough information to replicate and
resolve.
…On Wed, Mar 20, 2019, 5:33 PM Mikhail Mazurskiy ***@***.***> wrote:
@terinjokes <https://github.com/terinjokes> if you send a PR I'll happily
merge it. Also, sign the CLA please if you do so.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQsZdO3gU5a2hL8H0exUZ19E8s-c4DEks5vYtNOgaJpZM4bpzYf>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The golangci-lint rule does not depend on the SDK libraries. This results in a warning from govet (and possibly other linters):
WARN [runner] Can't run linter govet: can't typecheck package: can't init std types: import of type fmt.Stringer failed: can't find import: fmtBy adding
depset(sdk.libs)to the transitive dependencies list the compiled libraries are added to execution directory and everything is happy.bazel-tools/golangcilint/def.bzl
Lines 27 to 30 in 02472d8
The text was updated successfully, but these errors were encountered: