This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Add missing dependencies for golangci-lint #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM
…On Thu, Mar 28, 2019, 2:32 AM Mikhail Mazurskiy ***@***.***> wrote:
Fixes #50 <#50>, #51
<#51>.
Does it look ok @terinjokes <https://github.com/terinjokes>?
------------------------------
You can view, comment on, or merge this pull request online at:
#55
Commit Summary
- Add missing dependencies for golangci-lint
- Run buildifier
File Changes
- *M* golangcilint/def.bzl
<https://github.com/atlassian/bazel-tools/pull/55/files#diff-0> (2)
- *M* golangcilint/deps.bzl
<https://github.com/atlassian/bazel-tools/pull/55/files#diff-1> (16)
- *M* gometalinter/deps.bzl
<https://github.com/atlassian/bazel-tools/pull/55/files#diff-2> (4)
Patch Links:
- https://github.com/atlassian/bazel-tools/pull/55.patch
- https://github.com/atlassian/bazel-tools/pull/55.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#55>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQsZYbi7IcFS2SGoKuum53csEUbhDM8ks5vbIwegaJpZM4cPsOr>
.
|
scottgreenup
approved these changes
Mar 29, 2019
| url = _DOWNLOAD_URI.format(version=_VERSION, arch=arch) | ||
| prefix = _PREFIX.format(version=_VERSION, arch=arch) | ||
| url = _DOWNLOAD_URI.format(version = _VERSION, arch = arch) | ||
| prefix = _PREFIX.format(version = _VERSION, arch = arch) |
There was a problem hiding this comment.
Why did the formatting here (32-33) and on 13-18 change?
There was a problem hiding this comment.
@scottgreenup It looks like this was changed by buildifier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50, #51.
Does it look ok @terinjokes?