Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow #190

Merged
merged 4 commits into from
May 27, 2021
Merged

Add CI workflow #190

merged 4 commits into from
May 27, 2021

Conversation

declan-warn
Copy link
Contributor

Github action to replace Travis CI

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2021

⚠️ No Changeset found

Latest commit: 3bb1f6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@declan-warn
Copy link
Contributor Author

@danieldelcore it seems to be working now :)

Interesting it looks like the Travis pipeline wasn't catching linting errors? 🤔

Also I think you will need to make this new workflow a required one. It isn't preventing merges.

@danieldelcore
Copy link
Contributor

Here's a PR for the lint errors breaking our beautiful new Action

#191

@declan-warn
Copy link
Contributor Author

@danieldelcore seems like there was one more linting error that yarn lint:fix wasn't catching. I made a PR to fix it here and can confirm that's the last of them :) #193

@danieldelcore
Copy link
Contributor

Great work on this one mate! Let's merge it!

@danieldelcore danieldelcore merged commit eac0346 into master May 27, 2021
@danieldelcore danieldelcore deleted the add-github-ci-action branch May 27, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants