Arc 1444 keep probot running on stop #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgvozdev
reviewed
Oct 12, 2022
| @@ -24,8 +23,6 @@ export async function stop() { | |||
| return; | |||
| } | |||
| logger.info("Micros Lifecycle: Stopping queue processing"); | |||
| // TODO: change this to `probot.close()` once we update probot to latest version | |||
| probot.httpServer?.close(); | |||
bgvozdev
approved these changes
Oct 12, 2022
joshkay10
approved these changes
Oct 12, 2022
Haha didn't think of that, but yeah ! Actually me (ghe) is planning to review and merge your pr to kill probot, once we verify the new handler can process cloud web hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Stop the
stop the probot httpServerWhy
For each deployment, we don't want the existing stack to stop the probot (WORKER) http server from receiving healthcheck request, in case we want to rollback, we still need the existing stack (healthcheck endpoint) to function.
Added feature flags
N/A
Affected issues
ARC-1444
How has this been tested?
ddev
Multiple deploy to make sure it still works
rollback and make sure old stack works
However, before this change, I can't make old stack (health endpoint) cease functioning during rollback to verify my theory. I suspect it is due to healthcheck in worker group is quite special, the stack may still work even that healthcheck endpoint is broken. Too much micros assumption here, can't 100% prove anything. But my gut feeling tells me we should keep the server running.
Whats Next?
N/A