Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arc 1444 keep probot running on stop #1661

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Arc 1444 keep probot running on stop #1661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ab92a
ARC-1444 keep probot server running on stop command
gxueatlassian Oct 12, 2022
bca80a5
Merge branch 'main' into ARC-1444-keep-probot-running-on-stop
gxueatlassian Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/worker/startup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { probot } from "./app";
import { sqsQueues } from "../sqs/queues";
import { getLogger } from "config/logger";

Expand All @@ -24,8 +23,6 @@ export async function stop() {
return;
}
logger.info("Micros Lifecycle: Stopping queue processing");
// TODO: change this to `probot.close()` once we update probot to latest version
probot.httpServer?.close();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probot in worker? wtf


await sqsQueues.stop();

Expand Down