Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Node.js Language Metrics #300

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Enable Node.js Language Metrics #300

merged 3 commits into from
Dec 4, 2019

Conversation

tebriel
Copy link
Contributor

@tebriel tebriel commented Dec 3, 2019

We lost some nodejs metrics graphs, update the build packs and see if that re-enables them.
Fixes https://github.com/github/ecosystem-primitives/issues/485

@tebriel tebriel temporarily deployed to staging December 3, 2019 14:47 Inactive
@tebriel
Copy link
Contributor Author

tebriel commented Dec 3, 2019

Waiting on feedback from Heroku on why this isn't working

@tebriel tebriel temporarily deployed to staging December 4, 2019 16:06 Inactive
@tebriel
Copy link
Contributor Author

tebriel commented Dec 4, 2019

Turns out our package.json had the engine set to >= 12.x. Now that heroku's buildpack has node 13.x in it, our build dutifully installed node 13 (non-LTS bleeding edge). This PR will revert to 12.x and has a guard in the version to prevent being 13.x (until we decide we want that)

@tebriel
Copy link
Contributor Author

tebriel commented Dec 4, 2019

The metrics are back (in staging)!

Extended Node.js metrics

@tebriel tebriel requested a review from a team December 4, 2019 16:42
@tebriel
Copy link
Contributor Author

tebriel commented Dec 4, 2019

Related issue surfaced from this and Heroku Support: heroku/heroku-nodejs-plugin#14

zmoazeni
zmoazeni approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@zmoazeni zmoazeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome find!

@tebriel tebriel temporarily deployed to production December 4, 2019 18:07 Inactive
@tebriel tebriel merged commit 5d4bdaa into master Dec 4, 2019
@tebriel tebriel deleted the lost-heroku-graphs branch December 4, 2019 18:18
rachellerathbone pushed a commit that referenced this pull request Sep 15, 2021
@tebriel
Merge pull request #300 from integrations/lost-heroku-graphs
fc13205 
Enable Node.js Language Metrics
rachellerathbone pushed a commit that referenced this pull request Sep 16, 2021
@tebriel
Merge pull request #300 from integrations/lost-heroku-graphs
ac19960 
Enable Node.js Language Metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoazeni zmoazeni zmoazeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tebriel @zmoazeni