Upgrade to htmlunit 2.36.0, jetty 9.4.24 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rjatkins
commented
Dec 7, 2019
rjatkins
commented
- Ensure we use XmlPage.asText for getPageText, since getTextContent doesn't handle DOCUMENT nodes
- Avoid referencing explicit BrowserVersions - we don't care, so just use BrowserVersion.getDefault()
- Switch to using the BrowserVersionBuilder to reconfigure the UserAgent string to use in a BrowserVersion instead of clone
* Ensure we use XmlPage.asText for getPageText, since getTextContent doesn't handle DOCUMENT nodes * Avoid referencing explicit BrowserVersions - we don't care, so just use BrowserVersion.getDefault() * Switch to using the BrowserVersionBuilder to reconfigure the UserAgent string to use in a BrowserVersion instead of clone
* Use openjdk8 on ubuntu bionic (18.0.4)
* Also remove unneccessary install script, and deprecated sudo option * Also add explicit os, to avoid build validation warnings
* Workaround travis and install-jdk.sh completely failing for openjdk
Ganeshgautam
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.