chore(linting): Add eslint and fix initially found violations

affects: lerna-semantic-release-perform, lerna-semantic-release-pre, lerna-semantic-release-utils, lerna-semantic-release

.eslintignore

@@ -0,0 +1 @@
+packages/*/node_modules

.eslintrc.js

@@ -0,0 +1,15 @@
+module.exports = {
+  'extends': 'eslint:recommended',
+  'parserOptions': {
+    'ecmaVersion': 2015,
+    'sourceType': 'module',
+    'ecmaFeatures': {
+      'impliedStrict': true
+    }
+  },
+  'env': {
+    'node': true,
+    'es6': true,
+    'mocha': true,
+  }
+};

package.json

@@ -28,9 +28,10 @@
   ],
   "license": "MIT",
   "devDependencies": {
-    "lerna-semantic-release": "^9.0.1",
+    "cz-lerna-changelog": "1.1.0",
+    "eslint": "^3.14.1",
     "lerna": "2.0.0-beta.34",
-    "cz-lerna-changelog": "1.1.0"
+    "lerna-semantic-release": "^9.0.1"
   },
   "repository": {
     "type": "git",
@@ -39,7 +40,8 @@
   "scripts": {
     "semantic-release": "lerna-semantic-release pre && lerna-semantic-release post && lerna-semantic-release perform",
     "postinstall": "lerna bootstrap",
-    "test": "lerna run test"
+    "test": "lerna run test",
+    "lint": "eslint packages"
   },
   "release": {
     "branch": "caribou"

packages/lerna-semantic-release-perform/test/unit.js

@@ -1,6 +1,5 @@
 var io = require('lerna-semantic-release-io').mocks();
 var expect = require('expect.js');
-var path = require('path');
 var perform = require('../index');
 
 describe('perform', function() {

packages/lerna-semantic-release-pre/index.js

@@ -1,7 +1,6 @@
 var async = require('async');
 var path = require('path');
 var npmconf = require('npmconf');
-var rc = require('rc');
 
 var srRegistry = require('semantic-release/src/lib/get-registry');
 

packages/lerna-semantic-release-pre/test/unit.js

@@ -1,13 +1,12 @@
 var io = require('lerna-semantic-release-io').mocks();
 var expect = require('expect.js');
-var path = require('path');
 var pre = require('../index');
 
 function isPatchReleaseCommit (commit, expectations) {
   const name = expectations.name;
   const releaseHash = expectations.releaseHash;
   const version = expectations.version;
-  
+
   var isPatchReleaseCommit = true;
   var commitParts = commit.split('\n\n');
 

packages/lerna-semantic-release-utils/for-each-package.js

@@ -1,7 +1,4 @@
 var async = require('async');
-var path = require('path');
-
-var process = require('process');
 
 var log = require('./log');
 var bindTasks = require('./bind-tasks');

packages/lerna-semantic-release-utils/log.js

@@ -1,5 +1,5 @@
 if (typeof window !== 'undefined') {
-  module.exports = window.console;
+  module.exports = window.console;  // eslint-disable-line no-undef
 } else {
   var winston = require('winston');
   winston.cli();
@@ -9,4 +9,4 @@ if (typeof window !== 'undefined') {
     ]
   });
   module.exports = logger.cli();
-};
+}

packages/lerna-semantic-release/bin/lerna-semantic-release.js

@@ -2,23 +2,24 @@
 
 var task = process.argv[2];
 var io = require('lerna-semantic-release-io').default;
+var log = require('lerna-semantic-release-utils').log;
 
 var tasks = {
   pre: require('lerna-semantic-release-pre'),
   perform: require('lerna-semantic-release-perform'),
   post: require('lerna-semantic-release-post')
 };
 
-function erorrHandler(err) {
-  console.error(err);
+function errorHandler(err) {
+  log.error(err);
   process.exit(+!!err);
 }
 
 try {
   tasks[task]({
     io: io,
-    callback: erorrHandler
+    callback: errorHandler
   });
 } catch(err) {
-  erorrHandler(err);
+  errorHandler(err);
 }

packages/lerna-semantic-release/package.json

@@ -17,7 +17,8 @@
     "lerna-semantic-release-pre": "^4.1.1",
     "lerna-semantic-release-post": "^5.0.14",
     "lerna-semantic-release-perform": "^4.0.15",
-    "lerna-semantic-release-io": "^7.0.0"
+    "lerna-semantic-release-io": "^7.0.0",
+    "lerna-semantic-release-utils": "^4.0.0"
   },
   "peerDependencies": {
     "lerna": "^2.0.0-beta.31"