Run Service Catalog tests in CI #413
Conversation
| before_install: | ||
| # download things concurrently | ||
| - | | ||
| $( |
There was a problem hiding this comment.
Download all the things concurrently
.travis.yml
Outdated
| install: | ||
| - make setup-ci | ||
|
|
||
| script: | ||
| - make update-bazel | ||
| - make verify | ||
| - make test-ci | ||
| - go get sigs.k8s.io/kind |
There was a problem hiding this comment.
This now runs after unit tests and verification - they are most common source of failures and also run reasonably fast.
| - make docker | ||
| - make check | ||
| - | | ||
| kubectl create -f it/sc/ups-clusterservicebroker.yaml | ||
| sleep 5 |
There was a problem hiding this comment.
Give Service Catalog a few seconds to list classes from broker.
There was a problem hiding this comment.
add a polling loop like we have for cluster startup in setup_local_cluster
There was a problem hiding this comment.
I think this is good enough, it should take 1 second to list this broker.
| @@ -255,6 +256,12 @@ func SetupApp(t *testing.T, bundle *smith_v1.Bundle, serviceCatalog, createBundl | |||
| cli := smithClient.SmithV1().Bundles(cfg.Namespace) | |||
| b, err := cli.Get(bundle.Name, meta_v1.GetOptions{}) | |||
| if err == nil { | |||
| if t.Failed() { | |||
There was a problem hiding this comment.
If an integration test fails, it's useful to see the current state of the bundle.
ash2k
force-pushed
the
service-catalog-ci
branch
from
fd84985
to
87d4303
Compare
ash2k
force-pushed
the
service-catalog-ci
branch
from
9b3181f
to
ff592c8
Compare
| rm -f install.sh | ||
| chmod +x install_bazel.sh | ||
| ./install_bazel.sh --user | ||
| rm -f install_bazel.sh |
There was a problem hiding this comment.
For all of these commands, do you need to chain them with &?
There was a problem hiding this comment.
No, it works without them
Fixes #410.