Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla Get-WikiPage #58

Closed
brianbunke opened this issue Jun 18, 2017 · 4 comments
Closed

Vanilla Get-WikiPage #58

brianbunke opened this issue Jun 18, 2017 · 4 comments

Comments

@brianbunke
Copy link
Collaborator

Applies to branch develop (2.0) as of 2017/06/18.

Expected Behavior

Get-WikiPage returns all pages (or, once pagination is fixed, the correct page size).

Current Behavior

Get-WikiPage prompts for -PageID (a required parameter in the default parameter set), and fails when one is not provided.

Steps to Reproduce (for bugs)

  1. Get-WikiPage

Possible Solution

I do not yet have a technical solution to propose. This issue is primarily intended to be a discussion.

Context

I expect Get-WikiSpace and Get-WikiPage, with no parameters, to be fairly common "discovery commands" from new users. I'm using them to wrap my head around the changes in the develop branch, so it's a little weird to me that Get-WikiPage is erroring out.

I've labeled this "Milestone v2.0," but I just want us to get on the same page before that ships. Fixing this isn't absolutely required if we agree on something else.

If we agree that these commands should work in "vanilla" mode (no other specified parameters), this usage needs to be added to the integration test suite.

@brianbunke brianbunke added this to the v2.0 milestone Jun 18, 2017
@lipkau
Copy link
Member

lipkau commented Jun 19, 2017

I believe, that Get-WikiPage without any parameter is dangerous.
I know 3 productive Confluence server. On all of them:

  1. the result would be no help at all.
  2. it would take forever to complete.

We can do it. No problem.
But I would prefer for the user to have a bit more trouble to get all pages from all spaces:

Get-WikiSpace | Get-WikiPage

@brianbunke
Copy link
Collaborator Author

Yeah, I'm fine with that. A technical question:

With pagination working properly, I assume that Get-WikiPage would only fetch x (25?) pages, and therefore be less "dangerous" on an established instance. Is that correct?

@lipkau
Copy link
Member

lipkau commented Jun 19, 2017

No. It will fetch all in packs of 25 per request

@lipkau
Copy link
Member

lipkau commented Jun 23, 2017

can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants