This repository has been archived by the owner on Apr 7, 2021. It is now read-only.
IP restriction doesn't block a domain which resolves restricted IP address. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DNS localhost.bramp.net resolves to 127.0.0.1, which is on the restricted IP address list, however, to test matches the host name, not the actualy address.
…correct restricted IP address matching can be done. In addition minor refactoring to make the the code slightly cleaner.
|
I'd rather see us remove host restrictions entirely than add this. People shouldn't be running this anywhere with sensitive info. |
|
Just run it on heroku. ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup the DNS of the hostname before fetching the URL. This ensures correct restricted IP address matching can be done. In addition minor refactoring to make the the code slightly cleaner.