Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a
raise_error
middleware for Faraday GitHub client.It will raise on 401 a new
Escobar::Client::Error::Unauthorized
.Maybe we want to specialize errors per provider:
GitHub
orHeroku
to differentiate them higher in the stack.Why?
We raise
RepoNotFound
when the token has been revoked and return not accurate responses to users.Another solution?
Use
Octokit
instead of this custom code.That would allow us to reuse Octokit Client at places that do not fit the Escobar way:)