Add missing header #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add std namespace prefix to ifstream.
|
About "matpack.h" in constants.h. Using any other source for Numeric and Complex than matpack to define Numeric and Complex might be a good idea. This is all that I used of matpack in those files. |
|
@riclarsson Since constants.h currently only uses Numeric, not Complex, I'd prefer to stick with the minimal approach to only include what's needed. |
simonpf
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
Totally approve these changes.
To stop this from happening it should be enough to enforce that the first include in the .cc file is the corresponding header. Then these errors will appear during compilation. Anyhow, since this is a compile
time error, I don't think it is too critical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing clang-format, which reorders includes alphabetically, it became apparent that several of our headers are not self-contained. Not sure how to test for this globally.