Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eff to scala community build #130

Closed
benhutchison opened this issue Mar 30, 2018 · 4 comments
Closed

Add eff to scala community build #130

benhutchison opened this issue Mar 30, 2018 · 4 comments

Comments

@benhutchison
Copy link
Collaborator

Hi @etorreborre, both myself personally and REA are now building on top of Eff as a trusted platform.

One way we can strengthen the stability off Eff would be to include it in the Scala community build, so we'll know if future scala versions break it.

I work with Seth as Scala Swing module maintainer already, I'd be happy to volunteer as "build maintainer" for an Eff build.

I can send a PR to add Eff, just wanted to checkin with you first..?

@etorreborre
Copy link
Member

(back from vacations now): I definitely approve.

@benhutchison
Copy link
Collaborator Author

@benhutchison
Copy link
Collaborator Author

Seth asked if we could move the Eff benchmarks out of coreJVM so they aren't running in the community build, and so it doesnt depend on scalameter.

Moving https://github.com/atnos-org/eff/tree/master/jvm/src/test/scala/org/atnos/benchmark to root project seems to work...?

@benhutchison
Copy link
Collaborator Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants