-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Eff to build #709
Add Eff to build #709
Conversation
dbuild isn't able to resolve the scalameter dependency in coreJVM. I don't know why that's happening, but I'd rather not have to troubleshoot it. in general, we prefer to exclude benchmarks from the community build. could you move the scalameter stuff to a separate subproject, which we can then exclude? |
Seth, Ive moved the benchmark out of coreJVM in atnos-org/eff#136 |
this will need to be backported to 2.12.x after we unfreeze 2.12.x
thanks! next issue:
I could work around this by disabling |
Thanks Seth, that’s fixed now.
Ben
…On Wed, 25 Apr 2018 at 7:39 am, Seth Tisue ***@***.***> wrote:
thanks!
next issue:
[eff] [error] /Users/tisue/community.212/target-0.9.11/project-builds/eff-cb5fd474298c93c4fbaa0be2a22510b29ab7592f/shared/src/main/scala/org/atnos/eff/SafeEffect.scala:217: method apply in object PartialFunction is deprecated (since 2.12.5): For converting an ordinary function f to a partial function pf, use `val pf: PartialFunction[A, B] = { case x => f(x) }`. For creating a new PartialFunction, use an explicit type annotation instead, like in `val pf: PartialFunction[Int, String] = { case 1 => "one" }`.
[eff] [error] recoverThrowable[R, A, B](action, pureValue, PartialFunction(onThrowable))
[eff] [error] ^
[eff] [error] one error found
I could work around this by disabling -Xfatal-warnings in the context of
the community build, but I figure you'll probably want to address it
directly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#709 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05PrSr0XfKuy4KeX8AyD9NRBviKzVks5tr5t_gaJpZM4THryz>
.
|
I'll merge after we unfreeze the build post-2.12.6 |
thanks, glad to have this. |
No description provided.