Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eff to build #709

Merged
merged 6 commits into from
Apr 28, 2018
Merged

Add Eff to build #709

merged 6 commits into from
Apr 28, 2018

Conversation

benhutchison
Copy link
Contributor

No description provided.

@SethTisue SethTisue mentioned this pull request Apr 22, 2018
@SethTisue
Copy link
Member

SethTisue commented Apr 22, 2018

dbuild isn't able to resolve the scalameter dependency in coreJVM. I don't know why that's happening, but I'd rather not have to troubleshoot it. in general, we prefer to exclude benchmarks from the community build. could you move the scalameter stuff to a separate subproject, which we can then exclude?

@benhutchison
Copy link
Contributor Author

Seth, Ive moved the benchmark out of coreJVM in atnos-org/eff#136

this will need to be backported to 2.12.x after we unfreeze
2.12.x
@SethTisue
Copy link
Member

thanks!

next issue:

[eff] [error] /Users/tisue/community.212/target-0.9.11/project-builds/eff-cb5fd474298c93c4fbaa0be2a22510b29ab7592f/shared/src/main/scala/org/atnos/eff/SafeEffect.scala:217: method apply in object PartialFunction is deprecated (since 2.12.5): For converting an ordinary function f to a partial function pf, use `val pf: PartialFunction[A, B] = { case x => f(x) }`. For creating a new PartialFunction, use an explicit type annotation instead, like in `val pf: PartialFunction[Int, String] = { case 1 => "one" }`.
[eff] [error]     recoverThrowable[R, A, B](action, pureValue, PartialFunction(onThrowable))
[eff] [error]                                                  ^
[eff] [error] one error found

I could work around this by disabling -Xfatal-warnings in the context of the community build, but I figure you'll probably want to address it directly.

@benhutchison
Copy link
Contributor Author

benhutchison commented Apr 25, 2018 via email

@SethTisue
Copy link
Member

[info] Project eff-------------------------: SUCCESS (project rebuilt ok)

I'll merge after we unfreeze the build post-2.12.6

@SethTisue SethTisue self-assigned this Apr 25, 2018
@SethTisue SethTisue merged commit 0f7c841 into scala:2.12.x Apr 28, 2018
@SethTisue
Copy link
Member

thanks, glad to have this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants