Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings for Windows, Linux #132

Merged
merged 3 commits into from
Jun 9, 2014
Merged

Keybindings for Windows, Linux #132

merged 3 commits into from
Jun 9, 2014

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jun 1, 2014

In support of #120, #129, #131.

Let's get some keybindings for Windows and Linux boxes!

I probably made terrible choices of keybindings, so feel free to chime in @smashwilson, @erran, @Quojil, @rhoconlinux, @izuzak.

This was referenced Jun 1, 2014
@rgbkrk
Copy link
Member Author

rgbkrk commented Jun 1, 2014

Ok, I'm liking shift-enter when I explicitly want to run code frequently.

While only coding though, it's likely for me to still being hitting shift from a previous character (e.g. {) as I hit enter. Maybe others aren't as sloppy, but I'm guessing some will find this a major pain point.

@ghost
Copy link

ghost commented Jun 2, 2014

That's what trying to understand weird config files is for. I found that I needed to remove part of the config to get the new keybindings to work.

@rgbkrk
Copy link
Member Author

rgbkrk commented Jun 9, 2014

Alright, merging this as is. fingers crossed. I hope people are happy with these default bindings.

rgbkrk added a commit that referenced this pull request Jun 9, 2014
Keybindings for Windows, Linux
@rgbkrk rgbkrk merged commit 363bee5 into master Jun 9, 2014
@rgbkrk rgbkrk deleted the keybindings branch June 9, 2014 01:26
@rgbkrk
Copy link
Member Author

rgbkrk commented Jun 9, 2014

On second thought, I'm not going to leave the shift-enter keypress in. I'm really worried someone is going to accidentally run this at some weird state in their code, destroying all life as we know it.

@erran
Copy link
Collaborator

erran commented Jun 10, 2014

@rgbkrk I did end up running w/ shift-enter a couple of times by mistake. Guess I'm also slow to release shift when hitting non-alphanum keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants