This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Present certain TOC rendering options to the user through Atom config #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhevg
changed the title
lierdakil
reviewed
Oct 5, 2019
src/markdown-it-helper.ts
Outdated
| const _includeLevels = [] | ||
| for (let _i = 1; _i <= initState.tocDepth; _i++) { | ||
| _includeLevels.push(_i) | ||
| } |
There was a problem hiding this comment.
This looks somewhat ugly. Can't we shorten it? F.ex.
// snip
// array [1, 2, …, initState.tocDepth]
includeLevel: Array.from({length: initState.tocDepth}, (x, i) => i+1)
// snip
|
Thanks for submitting a pull request! I have a minor nitpick about the code style, it'd be great if you could fix that. If you don't have time to do that, no worries, I can do that myself, but that'll probably take a few days, since I'm short on spare time myself at the moment. |
|
Fixed. No worries, JavaScript/TypeScript is not my first language atm, so any style tips are appreciated. |
|
Thanks! Released as v3.11.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Present certain TOC rendering options to the user through Atom config #468