-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve issue #36 (Snippets not applied) #66
Conversation
Good find! Can you add some specs for this, so it won't happen again. We also need to be thinking about cleaning up old installs... we probably want to remove the redundant |
Well, I can try to add a test to check that uploaded and downloaded files are the same, as this was the case that would actually break the spec. As a matter of removing However I don't know how long will it take to me to write the spec, maybe it's worth to fix the thing in order to get it running (a minor release) and add the full-fledged update when there are more features to add. F. |
I changed my mind: in the specs the test for snippets.cson is missing while the other ones are already there. I'll fix it ASAP. F. |
Just copy the specs from keymap.cson https://github.com/Hackafe/atom-sync-settings/blob/master/spec/sync-settings-spec.coffee#L84-L91 |
That's what I said above in fact, I thought I'd do something more complicated but there's no need to! 😃 F. |
Ok, Travis does not complain with the new spec. F. |
Snippets not applied. Fixes #36
👍 |
Ref #36 |
Changes the name of the downloaded gist file to
snippets.cson
.F.