fix: add md- prefix to regular ion icons

[UziTech]

prefixes ion icon with md- when no prefix is specified

fixes #264

[ericcornelissen]

Though not ideal, I think this is the easiest solution to give some backwards compatibility w.r.t. #264. Most notably this will not cover the icons that are now prefixed with logo- (as they are not available with either ios- or md-). That said, this looks good to me and should probably be merged and released as soon as possible.

---

^{I think choosing the "refresh" icon for the new test is appropriate as it is unlikely to be removed in the future}

[VivaldoMendes]

I updated to 1.1.13 and some of my icons are working, while others are not (Start Remote Julia Process, Interrupt Julia,, Stop Julia and Run All). I am afraid of trying to do something that instead of correcting the existing problems, will create new ones (Atom is still working for me). Do you have any idea whether a new version will come out soon with these problems solved? Thank you.

[suda]

Like Eric said, defaulting to md- prefix would break the logo icons and the users might want to use the ios- prefix. I'll close this PR in favor of releasing tool-bar 1.2.0 with information about the changes. Thanks for doing this Tony!

[UziTech]

@VivaldoMendes the best solution seems to be changing the icon names to match the new version of ionicons prefixed with md- or logo-

[VivaldoMendes]

Thank you very much. I am relatively new to Atom and Julia. Where am I supposed to produce the changes? I tried tool-bar 1.2.0 + settings, but apparently it is not here. Then I tried Project+tool-bar+iconsets+ionicons. But here what should I do? I opened the file ionicons.css. There is a huge amount of lines with md- and logo. Which ones should I choose in order to get back the buttons for: Start Remote Julia Process Interrupt Julia Stop Julia Run All Well, I suppose the right command should be really simple, but if someone is not very much inside the process, it is not that simple. I convinced 33 master students to install Juno and Julia in their computers and give up Matlab. It was not easy, and with this kind of regular instability in Atom will not help much. Help would be appreciated. Best Vivaldo Mendes

…

________________________________ De: Tony Brix <notifications@github.com> Enviado: 3 de outubro de 2019 15:01 Para: suda/tool-bar <tool-bar@noreply.github.com> Cc: Vivaldo Manuel Mendes <vivaldo.mendes@iscte-iul.pt>; Mention <mention@noreply.github.com> Assunto: Re: [suda/tool-bar] fix: add `md-` prefix to regular ion icons (#265) @VivaldoMendes<https://github.com/VivaldoMendes> the best solution seems to be changing the icon names to match the new version of ionicons<https://ionicons.com/> prefixed with md- or logo- — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#265>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALSE3OYZLZHGHOW667HCXKTQMX3MDANCNFSM4I4YSWUA>.

[UziTech]

If there are any packages that supply the buttons for tool-bar then those packages will need to update their code

[ericcornelissen]

I convinced 33 master students to install Juno and Julia in their computers and give up Matlab. It was not easy, and with this kind of regular instability in Atom will not help much.

First off, this is not an instability in Atom but with a particular package in Atom.

I am relatively new to Atom and Julia. Where am I supposed to produce the changes? I tried tool-bar 1.2.0 + settings, but apparently it is not here.

Then I tried Project+tool-bar+iconsets+ionicons. But here what should I do? I opened the file ionicons.css. There is a huge amount of lines with md- and logo. Which ones should I choose in order to get back the buttons for:

Start Remote Julia Process
Interrupt Julia
Stop Julia
Run All

I don't think ionicons ever had icons for Julia, more likely you used specific icons from ionicons (like md-play-circle) for those Julia action. Can you share your toolbar configuration @VivaldoMendes, or where you got your configuration from? That would make it easier to help you find the icons you need.

[VivaldoMendes]

I am not a programmer. I am just migrating from Matlab into Julia and I find regular problems with (yes) some packages working in Atom. Suddenly, Atom stopped working. There was a problem with ink and I updated ink. There was information in Atom telling me that tool-bar 1.1.13 (Package providing customisable too bar) , by Suda, was also available for update. After I did the update to 1.1.13, some buttons vanished from what is known as the Toggle Tool Bar in Atom. I updated tool-bar to 1.2.0 and the problems remained. I have no idea what kind of dependency there is between the Toggle Tool Bar in Atom and tool-bar by suda. But I checked and there is a clear dependency: if in Atom I disable tool-bar by suda, the Toggle Toolbar in Atom will simply disappear. If I enable tool-bar by suda again, the Toggle Tool Bar is back (again without some of the buttons already mentioned). This dependency between Atom Toogle Tool Bar and suda tool-bar was not created by me. I just limited myself to install a package that is available in the setting up process of Atom. I did not apply any command at all. I wonder if by re-installing Julia and Atom I will get the same situation. I tried to insert some figures here to help, but I don´t know why the past thing does not work. Best Vivaldo : Eric Cornelissen <notifications@github.com> Enviado: 4 de outubro de 2019 10:35 Para: suda/tool-bar <tool-bar@noreply.github.com> Cc: Vivaldo Manuel Mendes <vivaldo.mendes@iscte-iul.pt>; Mention <mention@noreply.github.com> Assunto: Re: [suda/tool-bar] fix: add `md-` prefix to regular ion icons (#265) I convinced 33 master students to install Juno and Julia in their computers and give up Matlab. It was not easy, and with this kind of regular instability in Atom will not help much. First off, this is not an instability in Atom but with a particular package in Atom. I am relatively new to Atom and Julia. Where am I supposed to produce the changes? I tried tool-bar 1.2.0 + settings, but apparently it is not here. Then I tried Project+tool-bar+iconsets+ionicons. But here what should I do? I opened the file ionicons.css. There is a huge amount of lines with md- and logo. Which ones should I choose in order to get back the buttons for: Start Remote Julia Process Interrupt Julia Stop Julia Run All I don't think ionicons ever had icons for Julia, more likely you used specific icons from ionicons (like md-play-circle) for those Julia action. Can you share your toolbar configuration @VivaldoMendes<https://github.com/VivaldoMendes>, or where you got your configuration from? That would make it easier to help you find the icons you need. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#265>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALSE3O4BZCKWWW23ZFFI76DQM4E7HANCNFSM4I4YSWUA>.

[UziTech]

@VivaldoMendes looks like the julia client will get an update soon that should fix it

JunoLab/atom-julia-client#626

[VivaldoMendes]

Thank's a lot. There is a clear dependency of the Toggle Tool Bar in Atom on the tool-bar from suda. I'm glad that the problem will be solved sson. best VM

…

________________________________ De: Tony Brix <notifications@github.com> Enviado: 4 de outubro de 2019 16:41 Para: suda/tool-bar <tool-bar@noreply.github.com> Cc: Vivaldo Manuel Mendes <vivaldo.mendes@iscte-iul.pt>; Mention <mention@noreply.github.com> Assunto: Re: [suda/tool-bar] fix: add `md-` prefix to regular ion icons (#265) @VivaldoMendes<https://github.com/VivaldoMendes> looks like the julia client will get an update soon that should fix it JunoLab/atom-julia-client#626<JunoLab/atom-julia-client#626> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#265>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALSE3OZXAVULSDTIEKIX6F3QM5P3BANCNFSM4I4YSWUA>.

[ericcornelissen]

@VivaldoMendes I'm sorry your experience with regards to Atom package thus far hasn't been great. I definitely learned my lesson with regards to the fact that my Pull Request - the one that caused this issue - caused issues in other packages. And I will do my best to consider up-stream dependencies (i.e. the package that you use which use this project) in the future.

I guess a somewhat unfortunate side-effect of open source is that sometimes things go wrong because there isn't an entire software team behind the product you're using.

[VivaldoMendes]

That's fine. It's the cost we have to bear in order to have better open source software. Probably, it would be a good idea if Atom adopted a more prudent approach regarding the update of packages that may have upper dependencies within Atom. But I am just oppinionating; I know very little about these type of issues. Best VM

…

________________________________ De: Eric Cornelissen <notifications@github.com> Enviado: 4 de outubro de 2019 20:43 Para: suda/tool-bar <tool-bar@noreply.github.com> Cc: Vivaldo Manuel Mendes <vivaldo.mendes@iscte-iul.pt>; Mention <mention@noreply.github.com> Assunto: Re: [suda/tool-bar] fix: add `md-` prefix to regular ion icons (#265) @VivaldoMendes<https://github.com/VivaldoMendes> I'm sorry your experience with regards to Atom package thus far hasn't been great. I definitely learned my lesson with regards to the fact that my Pull Request - the one that caused this issue - caused issues in other packages. And I will do my best to consider up-stream dependencies (i.e. the package that you use which use this project) in the future. I guess a somewhat unfortunate side-effect of open source is that sometimes things go wrong because there isn't an entire software team behind the product you're using. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#265>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALSE3O4BPRT3XSN7NHFJM43QM6MGPANCNFSM4I4YSWUA>.