This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
[FIX] #452 #459
Closed
[FIX] #452 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Febry788
approved these changes
Jun 1, 2019
tonylikestoburns
approved these changes
Apr 17, 2020
mjrael89
reviewed
May 21, 2020
Comment on lines
+193
to
203
| content: ""; | ||
| background: linear-gradient(to bottom, black, transparent); | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 3px; | ||
| opacity: .125; | ||
| opacity: 0.125; | ||
| pointer-events: none; | ||
| z-index: 10; | ||
| } |
|
@mjrael89 wut ? |
ghost
approved these changes
Dec 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with multiline-tab package
Fix an issue with tool-bar package separator in vertical mode.
Description of the Change
multiline-tab:
Fix an issue that caused the .placeholder when dragging tabs to be 10rem height. Since multiline-tabs package disabled the vertical overflow of the tab bar to allow wrapping, this caused an issue where the placeholder would span multiple row of tabs. Now the placeholder with be the same height as the tab( 3rem, or 2.5rem if compact mode is enabled)
tool-bar:
Fix and issue that caused separator to be left-aligned instead of centered when the tool-bar is set in vertical mode. Also correct the separator color variable so it's not as light and work with more theme The color is now 5% lighter then the icon instead of 5% lighter than the text which make more sense.
Benefits
Fix a compatibility issue with two widely used package
Possible Drawbacks
None that I see.
Applicable Issues
#452, #460