fix: make the old decorations API type-safe #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to test some of the plugins before merging this and make sure they aren't going to break. |
|
Minimap cursor line fails |
aminya
force-pushed
the
type-safe-decorations-api
branch
from
cd4c214
to
f78fa69
Compare
This seems like a bug in that plugin. If I close the text editor, the plugin still keeps the decoration. |
aminya
force-pushed
the
type-safe-decorations-api
branch
from
0d6ad19
to
30ad2d6
Compare
UziTech
reviewed
May 10, 2021
aminya
commented
May 10, 2021
UziTech
requested changes
May 10, 2021
aminya
force-pushed
the
type-safe-decorations-api
branch
from
5066939
to
930ba15
Compare
|
I tried this now with all the plugins installed. I don't get any errors anywhere. Does this solve the Zen issue? |
|
Ya it looks like it does |
UziTech
approved these changes
May 10, 2021
|
🎉 This PR is included in version 4.39.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #793