This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Pane/PaneView API changes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2014 10:44
The matches for this method were mostly from Workspace::getActiveEditor. There ended up being only two actual uses. hashrocket/lib/hashrocket.coffee 51: editor = atom.workspace.activePane.getActiveEditor() nucleus/lib/core/adapters/workspace/atom/workspace_adapter.js 38: var editor = this.paneForPath(path).getActiveEditor();
| ::saveActiveItemAs() 0 0 0 | ||
| ::saveActiveItem() 0 0 0 | ||
| ::destroyInactiveItems() 0 0 0 | ||
| ::itemAtIndex(index) 0 0 1 |
There was a problem hiding this comment.
I think we'll need this for completeness. Can I only operate on the active item?
There was a problem hiding this comment.
I take this back, I like ::getItems()[index] better.
|
I like these dealing with item ordering: ::getItems()
::getActiveItem()
::addItem(item, index)
::activateItem(item)
::moveItem(item, newIndex)
::moveItemToPane(item, pane, index)I feel like we should have an easier way to handle siblings. I think whatever we do here, we should have the item siblings behave the same as panes. So we could do ::getPrevious()
::getNext()
Item::getPrevious()
Item::getNext()Though I think this might be hard because an item can be anything. So maybe we have ::getNextItem(item)
::getPreviousItem(item)
Workspace::getNextPane(pane)
Workspace::getPreviousPane(pane)Use cases being: focusing the next pane, moving an item to the next pane, closing the previous pane, etc. |
| @@ -405,24 +400,11 @@ Pane called packages a | |||
| ::addItem(item, index) 10 9 0 | |||
| ::getActiveItem() 8 6 0 | |||
| ::splitDown(params) 7 6 1 | |||
| ::activateNextItem() 4 3 0 | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the Pane and PaneView APIs and removes some underused methods from the API.
One thing we might want to consider, move the split methods from Pane to
Workspace. I think conceptually it makes sense to split the Workspace rather
than a Pane.