Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Windows doesn't have a security command #28

Closed
mcolyer opened this issue Oct 29, 2013 · 1 comment · Fixed by #42
Closed

Windows doesn't have a security command #28

mcolyer opened this issue Oct 29, 2013 · 1 comment · Fixed by #42

Comments

@mcolyer
Copy link
Contributor

mcolyer commented Oct 29, 2013

Moving this from atom/atom#1035

So we currently reference the security command here src/auth.coffee

@zcbenz has opened atom/node-keytar#3, so we can replace security -q find-generic-password -ws 'GitHub API Token' with require('keytar').findPasswordForService('GitHub API Token')

On Windows ideally we should be able to get the access token from GitHub's Windows client, but @paulcbetts mentioned that Github for Windows can't use the Windows Vault due to backwards compatibility.

Given all of that, I think it still makes sense to move forward with this change because atleast if they've signed in with Atom, we can reuse that key. For initial users I think we should just suggest that they bootstrap using an environment variable. Thoughts?

@benogle
Copy link
Contributor

benogle commented Nov 18, 2013

Fixed in 0e19842

@benogle benogle closed this as completed Nov 18, 2013
@benogle benogle reopened this Nov 19, 2013
kevinsawicki added a commit that referenced this issue Dec 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants