Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add keytar.findPasswordForService API #3

Merged
merged 5 commits into from
Oct 27, 2013
Merged

Add keytar.findPasswordForService API #3

merged 5 commits into from
Oct 27, 2013

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Oct 26, 2013

keytar.findPasswordForService can find the first password for the specified service, which is equivalent to the security -q find-generic-password command on OS X.

@zcbenz zcbenz mentioned this pull request Oct 26, 2013
Merged
10 tasks
@kevinsawicki
Copy link
Contributor

What do you think about calling it just findPassword since the other methods all take a service as the first parameter as well and don't have the ForService suffix?

@zcbenz
Copy link
Contributor Author

zcbenz commented Oct 27, 2013

Yeah I think findPassword is a better name, it's updated now.

zcbenz added a commit that referenced this pull request Oct 27, 2013
@zcbenz
Merge pull request #3 from atom/cz-find-password-for-service
e6b514d 
Add keytar.findPasswordForService API
@zcbenz zcbenz merged commit e6b514d into master Oct 27, 2013
@zcbenz zcbenz deleted the cz-find-password-for-service branch October 27, 2013 13:50
@kevinsawicki
Copy link
Contributor

Published a 0.12.0 release with this.

@mcolyer mcolyer mentioned this pull request Oct 29, 2013
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @kevinsawicki