apm clean on travis gets into infinite loop Removing @semantic-release

[DianaSuvorova]

Hello, I am trying to setup semantic release for atom package using travis.

But it hangs on Removing @semantic-release step: https://travis-ci.org/DianaSuvorova/atom-karma-test-runner/builds/278288913

@Arcanemagus from atom slack channel suggested that:apm's getModulesToRemove isn't handling the Scoped package naming syntax correctly (https://docs.npmjs.com/misc/scope)

Semantic release uses scoped package naming.

Travis owner suggested it is likely an apm script issue as well.

Thanks,
Diana

[50Wliu]

This has been recently fixed by #705 and should make its way into Atom 1.22.0.

[Arcanemagus]

Ha, I did search the issues before suggesting one was filed here, but ignored that as it was "installing" a scoped package. Thanks for pointing us in the right direction @50Wliu!

[smashwilson]

I'm still seeing this on Windows in apm 1.19.0:

master ≡ +0 ~1 -0 ! ~\src\github
> apm clean
Removing @babel\code-frame done
Removing @babel\generator done
Removing @babel\helper-function-name done
Removing @babel\helper-get-function-arity done
Removing @babel\helper-split-export-declaration done
Removing @babel\highlight done
Removing @babel\parser done
Removing @babel\template done
Removing @babel\traverse done
Removing @babel\types done
Removing @mrmlnc\readdir-enhanced done
Removing @sinonjs\formatio done
Removing @smashwilson\enzyme-adapter-react-16 done
Removing @smashwilson\enzyme-adapter-utils done
Removing @types\node done
Removing @babel\code-frame done
Removing @babel\generator Terminate batch job (Y/N)? Y

But once #796 is in, we should be able to fix this again by replacing apm clean with a call to npm prune.

[Arcanemagus]

Apparently CircleCI has an incredibly long timeout, just found Atom v1.31.0-beta0 builds running loops on there for the last 90 minutes!

https://circleci.com/gh/AtomLinter/linter-ruby/180 (1h 33m)
https://circleci.com/gh/AtomLinter/linter-ruby/189 (47 m)
https://circleci.com/gh/AtomLinter/linter-ruby/190 and later cancelled.
https://circleci.com/gh/AtomLinter/linter-jshint/609 (51 min)
https://circleci.com/gh/AtomLinter/linter-jshint/612 and later cancelled.
https://circleci.com/gh/AtomLinter/linter-php/498 (1h 31m)
https://circleci.com/gh/AtomLinter/linter-php/508 and later cancelled.
https://circleci.com/gh/AtomLinter/atom-linter-perlcritic/303 and later cancelled.

[Arcanemagus]

@smashwilson Note that this is a regression from #796, you can see that stable (v1.30.0) is working and beta (v1.31.0-beta0) is failing on an Ubuntu image, so this isn't just a Windows issue any more:
https://circleci.com/workflow-run/dfde81ee-4eae-4eab-a23b-9aa469ff495d