This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Update template themes for syntax-variables #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use proper variables all over.
| "private": true, | ||
| "description": "A short description of your theme", | ||
| "repository": "https://github.com/atom/__package-name__", | ||
| "private": false, |
There was a problem hiding this comment.
I think private: true is still nice here since it prevents accidentally publishing to npm.
There was a problem hiding this comment.
I guess I dont understand the private option, then.
We can publish things to apm as private and have them be public?
There was a problem hiding this comment.
Yeah, apm doesn't do anything with this value but npm does.
Maybe removing it completely is the right idea until we actually support it.
There was a problem hiding this comment.
I can get behind that
There was a problem hiding this comment.
Ok, I'm removing this.
Change org name back to atom
|
@kevinsawicki can I merge this? |
|
🚢 |
benogle
added a commit
that referenced
this pull request
Mar 3, 2014
Update template themes for syntax-variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syntax-variablesfile + use them in the correct place.Thinking it would be useful to maybe submodule the template-syntax. Only issue is the
__package-name__stuff which is missing from the template.Should go out at the same time as atom/atom#1644