-
Notifications
You must be signed in to change notification settings - Fork 295
Update template themes for syntax-variables #64
Conversation
Also use proper variables all over.
"private": true, | ||
"description": "A short description of your theme", | ||
"repository": "https://github.com/atom/__package-name__", | ||
"private": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think private: true
is still nice here since it prevents accidentally publishing to npm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I dont understand the private option, then.
We can publish things to apm as private and have them be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, apm
doesn't do anything with this value but npm does.
Maybe removing it completely is the right idea until we actually support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can get behind that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm removing this.
Change org name back to atom
@kevinsawicki can I merge this? |
🚢 |
Update template themes for syntax-variables
syntax-variables
file + use them in the correct place.Thinking it would be useful to maybe submodule the template-syntax. Only issue is the
__package-name__
stuff which is missing from the template.Should go out at the same time as atom/atom#1644