This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Prevent unnecessary native module rebuilding #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well... |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the system's host node has the same native module version as the downloaded one, don't rebuild native modules in the postinstall script. This should keep us from building libgit2 and oniguruma twice on every install. ✌️
Also: optionally disable automatic npm deduplication during postinstall by setting a
NO_APM_DEDUPEenvironment variable. I doubt we'll be able to get away with this in our real builds because of the Windows pathlength thing, but it'll help me narrow down the cause of build failures in atom/atom#17803.