This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Run tests on Appveyor #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My initial plan was to try to get this working in order to debug failures in atom/atom#19189, but annoyingly specifying x86 as a platform still seems to use an x64 image...still nice to have Windows coverage though. |
as-cii
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
This looks reasonable to me, nice job as usual @50Wliu!
Are you concerned at all about introducing unexpected changes to apm on Windows? My understanding is that this pull request was opened just to run tests on AppVeyor, but we're changing production code as well. I am cool with it, but just thought I'd raise the question.
Either way, 
!
|
@50Wliu We have since moved from running tests on other platforms and we are fully embracing Github Actions. For that reason, I don't think this is relevant anymore. |
aminya
added a commit
to atom-community/papm
that referenced
this pull request
Aug 9, 2021
Functional changes: - Include the mingw directory in the PATH (this directory contains many of the actual git functions, such as `git-pull`, `git-push`, and `git-upload-pack`). - Search `env.ProgramW6432` for Git before `env.ProgramFiles`, as `ProgramFiles` is not guaranteed to always point to the x64 Program Files directory. Technically, we should get the mingw path from `git --exec-path` (and this is what the GitHub package does), but that would mean making `git.addGitToEnv(env)` async, which would have been a much larger PR. From atom/apm#839 Co-Authored-By: Winston Liu <2766036+50Wliu@users.noreply.github.com>
aminya
added a commit
to atom-community/papm
that referenced
this pull request
Aug 9, 2021
Functional changes: - Include the mingw directory in the PATH (this directory contains many of the actual git functions, such as `git-pull`, `git-push`, and `git-upload-pack`). - Search `env.ProgramW6432` for Git before `env.ProgramFiles`, as `ProgramFiles` is not guaranteed to always point to the x64 Program Files directory. Technically, we should get the mingw path from `git --exec-path` (and this is what the GitHub package does), but that would mean making `git.addGitToEnv(env)` async, which would have been a much larger PR. From atom/apm#839 Co-Authored-By: Winston Liu <2766036+50Wliu@users.noreply.github.com>
aminya
added a commit
to atom-community/papm
that referenced
this pull request
Aug 9, 2021
Functional changes: - Include the mingw directory in the PATH (this directory contains many of the actual git functions, such as `git-pull`, `git-push`, and `git-upload-pack`). - Search `env.ProgramW6432` for Git before `env.ProgramFiles`, as `ProgramFiles` is not guaranteed to always point to the x64 Program Files directory. Technically, we should get the mingw path from `git --exec-path` (and this is what the GitHub package does), but that would mean making `git.addGitToEnv(env)` async, which would have been a much larger PR. From atom/apm#839 Co-Authored-By: Winston Liu <2766036+50Wliu@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get this working.
Functional changes:
git-pull,git-push, andgit-upload-pack).env.ProgramW6432for Git beforeenv.ProgramFiles, asProgramFilesis not guaranteed to always point to the x64 Program Files directory.Technically, we should get the mingw path from
git --exec-path(and this is what the GitHub package does), but that would mean makinggit.addGitToEnv(env)async, which would have been a much larger PR.