This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Send non-null initialized params
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
approved these changes
Jan 18, 2018
|
Thanks @daviwil, I'd also appreciate a release to avoid future Rls crashes. Any chance of getting |
|
Sure! I'll check with @damieng and see if there's anything else we'd want to get in for 0.8.1 this week. |
|
Thanks! I think we just want the overridable method for determining the autocomplete auto trigger and we can put out 0.8.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr sends non-null params with
initializednotifications.According to the spec the initialized parameters are not void (although they are empty). Sending
null, as we currently do, has started to cause latest Rls code to crash parsing this notification.