Merge pull request #19491 from atom/fix-compilation-cache-issue

Do not store null buffers on the cacheStore
atom · Jun 12, 2019 · 0226ae9 · 0226ae9
2 parents a0aab86 + aa987c7
commit 0226ae9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/native-compile-cache.js b/src/native-compile-cache.js
@@ -43,7 +43,7 @@ class NativeCompileCache {
     const script = new vm.Script(code, { filename, produceCachedData: true });
     return {
       result: script.runInThisContext(),
-      cacheBuffer: script.cachedData
+      cacheBuffer: script.cachedDataProduced ? script.cachedData : null
     };
   }
 
@@ -102,7 +102,7 @@ class NativeCompileCache {
           console.error(`Error running script ${filename}`);
           throw err;
         }
-        if (compilationResult.cacheBuffer !== null) {
+        if (compilationResult.cacheBuffer) {
           self.cacheStore.set(cacheKey, compilationResult.cacheBuffer);
         }
         compiledWrapper = compilationResult.result;