Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

package specific setting page become not accessible from v1.4.0 #10426

Closed
t9md opened this issue Jan 15, 2016 · 11 comments
Closed

package specific setting page become not accessible from v1.4.0 #10426

t9md opened this issue Jan 15, 2016 · 11 comments
Assignees

Comments

@t9md
Copy link
Contributor

t9md commented Jan 15, 2016

After upgraded to v1.4.0, setting can not accessible for page which have activationCommands, I first noticed in my package, but confirmed this issue is also happen for symbols-view package.

I'm not sure this issue is for settings-view or Atom core.
But I believe all package which have activationCommands in package.json have affect this issue.

OS X 10.9.5
Atom v1.4.0

When I reverted to v1.3.3 the issue not happen, OR when I removed activationCommands section from package.json issue not happen(can access setting page via settings-view)

The setting page I'm saying is package specific setting page by clicking setting button of specific package panel.

Screen capture with symbols-view package.

settings_ __users_tmaeda_github_symbols-view

settings_ __users_tmaeda_github_symbols-view

When I removed activationCommands from package.json, setting page become accessible.

settings_ __users_tmaeda_github_symbols-view

settings_ __users_tmaeda_github_symbols-view

@kandros
Copy link

kandros commented Jan 15, 2016

atom 1.4.0
osx 10.11.02

Not working for me too
screen shot 2016-01-15 at 08 57 48

@t9md
Copy link
Contributor Author

t9md commented Jan 15, 2016

@kandros What you want to say is not working for me right?
Since your screen capture not showing setting section

@kandros
Copy link

kandros commented Jan 15, 2016

@t9md typo 😁

@maxbrunsfeld
Copy link
Contributor

✨ Thanks for catching this and for the detailed report, @t9md!

@trois
Copy link

trois commented Jan 26, 2016

osx 10.11.2
atom 1.5.0-b1 => missing
atom 1.4.1 => missing
atom 1.3.3 => work (to avoid autoupdating, I made temporary change.
chmod 555 ~/Library/Application\ Support/com.github.atom.ShipIt )

@50Wliu
Copy link
Contributor

50Wliu commented Jan 26, 2016

@trois the fix isn't in the betas (yet). At the current rate it'll be in Atom 1.7.0, but it may be cherry-picked as a hotfix.

@lierdakil
Copy link
Contributor

Damn it all to hell! This issue pretty much kills all atom-haskell projects, since I use deferred activation extensively, for performance reasons, and most packages need to be configured.

@50Wliu
Copy link
Contributor

50Wliu commented Feb 1, 2016

Hey @lierdakil, the fix has been released in Atom 1.4.2 😄.

@lierdakil
Copy link
Contributor

Thanks.
1 февр. 2016 г. 23:27 пользователь "Wliu" notifications@github.com
написал:

Hey @lierdakil https://github.com/lierdakil, the fix has been released
in Atom 1.4.2 [image: 😄].


Reply to this email directly or view it on GitHub
#10426 (comment).

@jonobacon
Copy link

It looks like this issue may be back. See AtomLinter/linter-pylama#33 for details.

@lock
Copy link

lock bot commented Apr 11, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked and limited conversation to collaborators Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants