Serialized markers are unserialized at the bottom of the buffer

[benogle]

You can see this in bookmarks:

1. Make a bookmark.
2. Reload the editor
3. See bookmark at the bottom of the buffer. Why?

My assumption is that the buffer is reloaded / set again after the markers are deserialized. If anyone has any insight into this, lemmie know. I'm going to dig in a bit.

atom/bookmarks#3

[nathansobo]

Curious what you're seeing. My first suspicion would be that we're overwriting the text of the buffer, but cursors remain stationary on reload so that seems to rule that out.

[benogle]

This is because we call TextBuffer::load() after creation which loads the buffer from disk, runs a TextBuffer::setText(), and displaces all the markers. A quick fix would be to not reload unless the disk buffer is different from the current state of the editor.

I'm going to take a stab at making TextBuffer::setText() to do a line-wise diff application tomorrow. (using https://github.com/kpdecker/jsdiff; also take a look at https://github.com/cemerick/jsdifflib)

[nathansobo]

⛅

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!