Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Atom editor renders random text over each other. #15761

Closed
1 task done
ungb opened this issue Sep 27, 2017 · 12 comments
Closed
1 task done

Atom editor renders random text over each other. #15761

ungb opened this issue Sep 27, 2017 · 12 comments

Comments

@ungb
Copy link
Contributor

ungb commented Sep 27, 2017

Prerequisites

Description

Atom editor renders random text over each other.

I am currently unable to get repro steps for this but have screenshots of the scenario

Expected behavior: [What you expect to happen]
Text should show up and other lines shouldn't be rendered on top

Actual behavior: [What actually happens]
Additional random lines are rendered above current lines and don't disappear after scrolling.
image

image

Reproduces how often: [What percentage of the time does it reproduce?]
I can't repro this again and unsure what I did to get to this scenario

Versions

Atom    : 1.22.0-dev-1880e1401
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

While scrolling you can see it updates the line numbers but there's additional lines that just stay there.
scrolling

/CC @nathansobo @as-cii

@rsese
Copy link
Contributor

rsese commented Sep 28, 2017

I remember this issue that looks similar /cc #15549?

/cc @Ben3eeE because I remember you had a go at reproducing the issue above.

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Sep 28, 2017

Yeah I was able to reproduce #15549 but I was unable to find consistent repro steps. I can have a look at it again later.

@ungb did you use folds?

@nathansobo
Copy link
Contributor

I think we should simplify our line update logic dramatically and see if it helps. There are only 6 lines per tile, so we should be able to afford a bit more brute-force of an approach than we're currently taking I think.

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Sep 28, 2017

My repro was using the version mentioned in #15549 because they said in that issue it reproduced 100%. I was able to reproduce in that version but couldn't find steps to try in more recent versions.

Never reported back because more recent versions contained relevant fixes for soft wraps and folds. I'll check it out in a more recent version to see if I can repro it again somehow. @ungb We can try and find reliable steps later today when pairing.

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Sep 28, 2017

Ok I have steps to reproduce in safe mode on beta using the file in #15549 (comment)

Gif of reproduction:

that double line thing

@maxbrunsfeld
Copy link
Contributor

Ok I have steps to reproduce in safe mode on beta

👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏

@pbarbiero
Copy link

@Ben3eeE fwiw, I see this (or #15549) fairly regularly in 1.20.1, typically when I am folding and using prettier-atom.

@as-cii
Copy link
Contributor

as-cii commented Oct 5, 2017

Unfortunately, we were able to reproduce this bug again after merging #15800. As a result, we decided to write a randomized test to verify some interactions in the rendering code path and managed to discover another problem that may be the cause of this issue.

We are already working on fixing it and will submit a pull-request shortly.

@drewlandis
Copy link

I'm still seeing the random text in my Atom editor. I'm running the following:
(from Atom > About Atom)

Atom: 1.22.1 X64

(from View > Developer > Toggle Developer Tools > console.log(process.versions)):

Electron: 1.6.15
Chrome: 56.0.2924.87
Node: 7.4.0

Is there anything glaring I need to update, or would it be better to open a new bug after following all of the appropriate bug steps (reproduce in safe-mode, etc).

Thanks!

@50Wliu
Copy link
Contributor

50Wliu commented Dec 8, 2017

@drewlandis if this is occurring after folding, it may have to do with #16289 and #15831. Otherwise, it would be ✨ if you could open a new issue!

@drewlandis
Copy link

drewlandis commented Dec 8, 2017

Shucks. Unfortunately, this is not after folding. Thanks, I'll open a new issue. I'll try safe-mode and then follow the debugging steps and if the error still occurs, then I'll open a new issue.

@lock
Copy link

lock bot commented Jun 6, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants