Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: Timeout in test of find-and-replace:copy-path #19480

Closed
nathansobo opened this issue Jun 10, 2019 · 1 comment · Fixed by #19505 or atom/find-and-replace#1091

Comments

@jasonrudolph

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

We had hoped that this issue was resolved by #19505, but we saw this flake again last night:

https://github.visualstudio.com/Atom/_build/results?buildId=43605&view=logs&jobId=6de74252-975b-522d-7a3d-227ca79ca6c1&taskId=b7ded238-9370-50c9-8500-e02f948495a4&lineStart=473&lineEnd=477&colStart=1&colEnd=9

That build includes the changes from #19505 (i.e., the upgrade to find-and-replace v0.218.13), so I think that means that this flake is still an issue. With that in mind, I'm going to re-open this issue. If I'm interpreting these results incorrectly and this issue should remain closed, just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.