Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Atom hangs when "}" is deleted when editing .thrift file #7644

Closed
prashantv opened this issue Jul 2, 2015 · 7 comments
Closed

Atom hangs when "}" is deleted when editing .thrift file #7644

prashantv opened this issue Jul 2, 2015 · 7 comments
Assignees

Comments

@prashantv
Copy link

I have the language-thrift package (https://atom.io/packages/language-thrift) installed.

When editing a Thrift file, enter the following code:

exception SimpleErr {
  1: string message
}


service SimpleService {
  void Simple() throws (1: SimpleErr simpleErr)
}

If you delete the "}" at the end of the exception block, the whole editor freezes up.

This seems to be an issue with the grammar / syntax parsing.

@kubetz
Copy link

kubetz commented Jul 2, 2015

If you close all running instances of atom, run it in safe mode with atom --safe and it stops freezing, then it is not a problem of atom/atom you need to open an issue for language-thrift plug-in here.

Also providing information about atom version and operating system always helps 👍 .

@izuzak
Copy link
Contributor

izuzak commented Jul 2, 2015

I was able to reproduce this, but not sure where the problem might be. @nathansobo can you take a quick look? Could a "bad" grammar cause such behavior and is there anything we can do about that?

@nathansobo
Copy link
Contributor

Taking a look.

@mnquintana mnquintana added the bug label Jul 2, 2015
@nathansobo
Copy link
Contributor

The fix for this is nontrivial, but I'm working on it. Could take some time.

@nathansobo
Copy link
Contributor

Thanks for the detailed report and sorry for the hassle. This will be fixed in 1.0.1, scheduled to go out this week.

@prashantv
Copy link
Author

Thanks for fixing this so quickly Nathan! Looking forward to the next release

@lock
Copy link

lock bot commented Jan 21, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants