This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Use %F instead of %U for file variable in desktop file #11284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The desktop entry specification states that %U is for URLs and %F is for files. Since atom doesn't support URLs, we should use %F. Fixes atom#2320.
jonmast
changed the title
|
I confirm this proposal fixes #2320. This PR need to be merged. |
|
Nice catch! Thanks so much for fixing this – sorry it took so long to review. 🚀 🌔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desktop entry specification states that %U is for URLs and %F is for
files. Since atom doesn't support URLs, we should use %F. Fixes #2320.